Skip to content

Remove cling 1.0 support + Make llvm 16 minimum version #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 4, 2025
Merged

Remove cling 1.0 support + Make llvm 16 minimum version #581

merged 12 commits into from
Jun 4, 2025

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This PR will remove support for cling 1.0 from CppInterOp, and make the minimum version of llvm supported as 16.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton changed the title Remove cling 1.0 support + Make llvm 16 minimum version [wip] Remove cling 1.0 support + Make llvm 16 minimum version May 19, 2025
@mcbarton mcbarton marked this pull request as draft May 19, 2025 12:11
@mcbarton
Copy link
Collaborator Author

The workflows of this PR are expected to fail for cling jobs until #580 is in. Once I have checked that all clang-repl jobs work still pass I will move onto refining compatibility.h which can now have some parts removed.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov Codecov
Copy link

codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.66%. Comparing base (90ad431) to head (39eebe5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   77.66%   77.66%           
=======================================
  Files           9        9           
  Lines        3743     3743           
=======================================
  Hits         2907     2907           
  Misses        836      836
Files with missing lines Coverage Δ
lib/CppInterOp/CXCppInterOp.cpp 48.86% <ø> (ø)
lib/CppInterOp/Compatibility.h 91.96% <ø> (ø)
lib/CppInterOp/CppInterOp.cpp 85.09% <100.00%> (ø)
Files with missing lines Coverage Δ
lib/CppInterOp/CXCppInterOp.cpp 48.86% <ø> (ø)
lib/CppInterOp/Compatibility.h 91.96% <ø> (ø)
lib/CppInterOp/CppInterOp.cpp 85.09% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton mentioned this pull request May 20, 2025
Merged
4 tasks
@mcbarton mcbarton force-pushed the Remove-cling-1.0-support branch from 3ed229b to 3327c5f Compare May 22, 2025 13:33
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton mentioned this pull request May 22, 2025
Merged
@mcbarton mcbarton force-pushed the Remove-cling-1.0-support branch from 3327c5f to 368fe80 Compare May 22, 2025 18:24
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton force-pushed the Remove-cling-1.0-support branch 2 times, most recently from 0eb9faa to 6327123 Compare May 23, 2025 10:59
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton force-pushed the Remove-cling-1.0-support branch from 6327123 to fa24b4a Compare May 28, 2025 13:37
@mcbarton mcbarton force-pushed the Remove-cling-1.0-support branch from cdb33eb to c385e4f Compare May 28, 2025 13:57
@mcbarton mcbarton changed the title [wip] Remove cling 1.0 support + Make llvm 16 minimum version Remove cling 1.0 support + Make llvm 16 minimum version May 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton force-pushed the Remove-cling-1.0-support branch from 57d930b to c53c9c8 Compare May 28, 2025 14:22
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton marked this pull request as ready for review May 28, 2025 14:38
@vgvassilev vgvassilev requested a review from aaronj0 May 28, 2025 14:56
mcbarton
mcbarton commented May 28, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

aaronj0
aaronj0 requested changes May 29, 2025
View reviewed changes
@mcbarton mcbarton mentioned this pull request May 29, 2025
Merged
4 tasks
@mcbarton mcbarton requested a review from aaronj0 May 29, 2025 14:09
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

clang-tidy review says "All clean, LGTM! 👍"

aaronj0
aaronj0 approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@aaronj0 aaronj0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @mcbarton can you rebase on main and squash into a single commit?

@mcbarton
Copy link
Collaborator Author

mcbarton commented Jun 4, 2025

LGTM! @mcbarton can you rebase on main and squash into a single commit?

Thanks @aaronj0 . I've merged main into this PR. Once the ci passes I will squash and merge.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton merged commit dd50000 into compiler-research:main Jun 4, 2025
90 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronj0 aaronj0 aaronj0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcbarton @aaronj0